Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revit crash on Assistant launch #206

Closed
MohamedAsli opened this issue May 9, 2023 · 17 comments
Closed

Revit crash on Assistant launch #206

MohamedAsli opened this issue May 9, 2023 · 17 comments
Labels
bug Something isn't working needs investigation issue / topic that needs more investigation in order to decide what action to take. OkPy

Comments

@MohamedAsli
Copy link

MohamedAsli commented May 9, 2023

Revit simply crashes when attempting to launch the Assistant.

To Reproduce

  1. New okpy file
  2. Click on '🤖Assistant'
  3. "An unrecoverable error has occurred. The program will now be terminated..."

image

@MostafaElAyoubi
Copy link
Member

Hey there @MohamedAsli !
Super excited you're already giving the assistant a shot! :)
In which version of Revit are you experiencing this issue?

@MostafaElAyoubi MostafaElAyoubi added bug Something isn't working OkPy needs investigation issue / topic that needs more investigation in order to decide what action to take. labels May 9, 2023
@MohamedAsli
Copy link
Author

Hi @MostafaElAyoubi
Sorry for the lack of info

Revit 2020.2.9
20220517_1515(x64)

@MostafaElAyoubi
Copy link
Member

Thanks for the info! We're having à hard time reproducing the issue on our end. Could you please see if you get the same crash on another version of Revit?

@MohamedAsli
Copy link
Author

MohamedAsli commented May 10, 2023

I've tried on 2021 and 2022.1.3, got the same problem.
Here's a snippet where we see the raised exception from my journal file on 2022, I don't know if it helps
I've disabled all my plugins, only Orkestra and Okpy left

"""
'E 10-May-2023 11:44:44.274; 0:<
Jrn.RibbonEvent "Execute external command:CustomCtrl_%CustomCtrl_%OkPy%OkPy%OkPy:OkPyRevitLoader.Commands.OpenOkPyCommand"
' 0:< ::63:: Delta VM: Avail -168 -> 134210705 MB, Used +157 -> 841 MB, Peak +138 -> 851 MB; RAM: Avail -134 -> 21962 MB, Used +165 -> 975 MB, Peak +150 -> 985 MB
' 0:< GUI Resource Usage GDI: Avail 9141, Used 859, User: Used 427
' 1.780241 1:<<<API External Command Time
'H 10-May-2023 11:44:46.068; 0:<
Jrn.Data _
"APIStringStringMapJournalData" , 0
' 0:< ::63:: Delta VM: Avail -7 -> 134210699 MB, Used +1 -> 842 MB; RAM: Avail -12 -> 21950 MB, Used +2 -> 977 MB
' 0:< GUI Resource Usage GDI: Avail 9130, Used 870, User: Used 438
'E 10-May-2023 11:44:47.755; 0:<
Jrn.AddInEvent "AddInJournaling" , "WpfWindow(,OkPy for Revit).WpfButton(0,NewOkPyTool).Click()"
'E 10-May-2023 11:44:47.756; 0:<
' [Jrn.WpfEvent.OkPy_for_Revit.NewOkPyTool] Rvt.Attr.WindowType: WpfWindow Rvt.Attr.WindowName: OkPy_for_Revit Rvt.Attr.ControlType: WpfButton Rvt.Attr.ControlName: NewOkPyTool Rvt.Attr.Action: Click()
' 0:< ::65:: Delta VM: Avail -20 -> 134210679 MB, Used +31 -> 873 MB, Peak +50 -> 902 MB; RAM: Avail -32 -> 21919 MB, Used +36 -> 1014 MB, Peak +54 -> 1040 MB
' 0:< GUI Resource Usage GDI: Avail 9125, Used 875, User: Used 450
'E 10-May-2023 11:47:08.181; 0:<
Jrn.AddInEvent "AddInJournaling" , "WpfWindow(,OkPy for Revit).WpfButton(0,OkPyAssistant).Click()"
'E 10-May-2023 11:47:08.181; 0:<
' [Jrn.WpfEvent.OkPy_for_Revit.OkPyAssistant] Rvt.Attr.WindowType: WpfWindow Rvt.Attr.WindowName: OkPy_for_Revit Rvt.Attr.ControlType: WpfButton Rvt.Attr.ControlName: OkPyAssistant Rvt.Attr.Action: Click()
' 0:< Exception occurred
'C 10-May-2023 11:47:08.875; 0:< ExceptionCode=0xe0434352 ExceptionFlags=0x00000001 ExceptionAddress=00007FFCD95FCB69
'C 10-May-2023 11:47:08.875; BC: 0,0,1
' 0:< System (MB) [Available / Total ] [Revit Memory Usage (MB) ]
' 0:< RAM Statistics: 21911 / 32509 1022=InUse 1040=Peak
' 0:< VM Statistics: 134210679 / 134217727 874=InUse 902=Peak
' 1:< ::67:: Delta VM: Avail +16 -> 134210696 MB, Used 873 MB; RAM: Avail +237 -> 22156 MB, Used +8 -> 1022 MB
' 1:< GUI Resource Usage GDI: Avail 9125, Used 875, User: Used 449
'C 10-May-2023 11:47:11.721; Revit worker 1 closed cleanly
'C 10-May-2023 11:47:11.723; [00003700]QueueMinder stopped
'C 10-May-2023 11:47:11.723; 1:< logging finished virtualization services
'C 10-May-2023 11:47:11.723; 1:< logging finished worker services
'C 10-May-2023 11:47:11.724; 1:< logging erased queues
' 2.844670 1:<<<Terminating RevitWorker Processes
' 0:< ::67:: Delta VM: Avail +191 -> 134210888 MB, Used -156 -> 718 MB; RAM: Avail +244 -> 22401 MB, Used -162 -> 860 MB
' 0:< GUI Resource Usage GDI: Avail 9125, Used 875, User: Used 432
' 0:< CefSharp has been shutdown successfully!
' 0:< Unconverted MessageBox "Une erreur bloquante s'est produite. Le programme va se fermer. Toutes vos données ont récemment été enregistrées, vous ne devez donc pas créer de fichiers de récupération.
"""

@adriangrosu2907
Copy link

Hi @MostafaElAyoubi

I am encountering the same behavior on Revit 2022.1. If I can further assist with information about this, let me know.

@MostafaElAyoubi
Copy link
Member

Thank you very much for the précisions. Could you please share the list of addins you have installed ? This could be a conflict with resources loaded by other revit addins but we're not sure yet.

@adriangrosu2907
Copy link

On my end, I do not have any other add-ins installed so far, the first to install was Orksestra :) after a clean install of Revit.

@MostafaElAyoubi
Copy link
Member

I love your priorities @adriangrosu2907 😄 !! Which version of windows are you on?

@MohamedAsli
Copy link
Author

For Revit 2022 I've disabled all non-autodesk plugins.
I made another test on a brand new installation of revit 2024, same bug :/
No other addins except the Autodesk ones ⬇
image

@MostafaElAyoubi
Copy link
Member

This is super helpful thank you very much🙏

@MostafaElAyoubi
Copy link
Member

can you please try re-downloading the installer and re-installing?

@pkitchenks
Copy link

I'm having a similar issue even after downloading the updated installer. Revit 2024 with no additional add-ins installed.

@MohamedAsli
Copy link
Author

Uninstalled and reinstalled.
A good step forward, now the assisant window opens fine.

The first test revit crashed just after my first prompt
image

The second test, it crashed after the second prompt
image

@LeeFried
Copy link

I decided to give this a shot. I uninstalled v1.6.1 and performed a clean install of v1.7.1, with no change to my Revit installations.
If I open OkPy, create a tool, then click “Assistant”, it crashes Revit. It crashes all versions from 2021-2024.
We don’t have the luxury of reinstalling Revit on every user’s computer to remedy this.

@MostafaElAyoubi
Copy link
Member

Thanks for reporting @LeeFried .
Réinstalling orkestra only seemed to work for some people. It is inconsistent though. We're still investigating.

@MostafaElAyoubi
Copy link
Member

@MohamedAsli it is à step forward for sûre. We're probably going to share à débug installer to try and track down and fix this . I'll reach out soon.

@MostafaElAyoubi
Copy link
Member

Fixed in 1.7.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs investigation issue / topic that needs more investigation in order to decide what action to take. OkPy
Projects
None yet
Development

No branches or pull requests

5 participants