Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Because of FXBlurView, any view behind the popup that was hidden is shown after the popup is dismissed #103

Closed
victoraraujo01 opened this issue Feb 1, 2017 · 8 comments
Assignees

Comments

@victoraraujo01
Copy link

victoraraujo01 commented Feb 1, 2017

Report

Environment

Please provide information on your development environment, so we can build with the same scenario.

  • Xcode version (e.g. 8.0): 8.2.1
  • PopupDialog version (e.g. 0.5.0): 0.5.3
  • Minimum deployment target (e.g. 9.0): 10.0
  • Language (Objective-C / Swift): Swift
  • In case of Swift - Version (e.g. 3.0): 3.0

Dependency management

If you are not using any dependency managers, you can remove this section.

Please note: If you are using CocoaPods with Xcode 8, CocoaPods 1.1.0 is required.

  • Dependency manager (e.g. CocoaPods): CocoaPods
  • Version (e.g. 1.1.0): 1.1.1

What did you do?

Presented a popup over a view that has a subview hidden

What did you expect to happen?

After the popup is dismissed, the view should be exactly as it was before, with the subview hidden.

What happened instead?

After the popup is dismissed, the hidden view is being displayed. This is being caused by FXBlurView, see nicklockwood/FXBlurView#126 for more details.

@mwfire
Copy link
Member

mwfire commented Feb 2, 2017

Thanks for reporting this, I will look into it asap.

@mwfire mwfire self-assigned this Feb 2, 2017
@mwfire
Copy link
Member

mwfire commented Feb 4, 2017

I tested this with the example app and followed the links. It seems this bug exists, however I cannot reproduce it. Can you please attach an example project? Thanks!

@victoraraujo01
Copy link
Author

Sorry it took so long, haven't had much time in the last week to take a look at this.

Here's a project reproducing the error. It seems that it's more of an edge case than I thought, very specific to what I had in my project. I only managed to recreate the issue with a hidden UIActivityIndicator inside a Stack View. You can try it out in the project by pressing the "Open popup" button and verifying the the activity indicators in all cells are displayed.

PopupTest.zip

State before pressing "Open Popup"
print1

State after pressing "Open Popup"
print2

@mwfire
Copy link
Member

mwfire commented Feb 16, 2017

Thanks for the effort @victoraraujo01, I will look at this asap!

@mwfire
Copy link
Member

mwfire commented Feb 23, 2017

Ready for testing on develop: pod 'PopupDialog', :git => 'https://github.com/Orderella/PopupDialog.git', :branch => 'development'

@terenzeyuen
Copy link

Having this issue too.

@terenzeyuen
Copy link

I can confirm development branch fixes it.

@mwfire
Copy link
Member

mwfire commented Mar 18, 2017

Released with v. 0.5.4

@mwfire mwfire closed this as completed Mar 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants