Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resources CDN replaces inline script src #7990

Closed
deanmarcussen opened this issue Dec 14, 2020 · 1 comment · Fixed by #8042
Closed

Resources CDN replaces inline script src #7990

deanmarcussen opened this issue Dec 14, 2020 · 1 comment · Fixed by #8042

Comments

@deanmarcussen
Copy link
Member

When using an external CDN for locally hosted scripts the CdnBaseUrl property replaces the inline script with the url src of the cdn.

What should be rendered as

<script> ... some javascript </script>

becomes

<script src="https://mycdn.azureedge.net"</script>
@jtkech
Copy link
Member

jtkech commented Dec 14, 2020

Oops ;)

@deanmarcussen deanmarcussen mentioned this issue Dec 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correctly generate cdn base url for local scripts OrchardCMS/OrchardCore
2 participants
@jtkech @deanmarcussen