Modules don't use OC default JsonSerializerOptions

[arkadiuszwojcik]

Describe the bug

Wrong (probably ASP.NET default) JsonSerializerOptions when using IOptions<JsonSerializerOptions> as module dependency.

Orchard Core version

Current master: b3d6591 (and all previous versions)

To Reproduce

Modify blog.recipe by adding step:

{
  "name": "feature",
  "enable": [
    ...
    "OrchardCore.UrlRewriting",
  ]
},
{
  "name": "UrlRewriting",
  "rules": [
    {
      "Source": "Rewrite",
      "Name": "Media rewrite rule",
      "Pattern": "^/img/(.*)$",
      "SubstitutionPattern": "/media/$1",
      "IsCaseInsensitive": true,
      "IgnoreQueryString": false,
      "SkipFurtherRules": true
    }
  ]
}

Expected behavior

Above step will fail because "rules" start from lower case but it will work when it will be replaced by "Rules". It is failing because provided JsonSerializerOptions are case sensitive. I would expect that JOptions.Default are provided.

Cause

This is happening because UrlRewritingStep dependency IOptions<JsonSerializerOptions> is not injecting default OrchardCore json serializer options. Default OC options ignore case sensivity, also those options have bunch of converters but here provided options have no converters. I suspect default ASP.NET IOptions<JsonSerializerOptions> is used instead.

[MikeAlhayek]

@arkadiuszwojcik Do you want to submit a PR for this?

Remove the second argument from this line:

https://github.com/OrchardCMS/OrchardCore/blob/main/src/OrchardCore.Modules/OrchardCore.UrlRewriting/Recipes/UrlRewritingStep.cs#L34

[github-actions]

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.