Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage settings are visible when feature is disabled #17244

Closed
jbytes1027 opened this issue Dec 14, 2024 · 3 comments · Fixed by #17321
Closed

Homepage settings are visible when feature is disabled #17244

jbytes1027 opened this issue Dec 14, 2024 · 3 comments · Fixed by #17321
Labels
Milestone

Comments

@jbytes1027
Copy link
Contributor

Started from a blank template and made a content item the homepage, and received a message saying it was the homepage, only for it not to be at /. This was because the home route feature was not enable.

image

Proposal

Disable all homepage related UI when the home page feature is disabled.

@sebastienros sebastienros added this to the 2.x milestone Dec 19, 2024
Copy link
Contributor

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

@jbytes1027
Copy link
Contributor Author

I'll start working on this.

@jbytes1027
Copy link
Contributor Author

jbytes1027 commented Jan 8, 2025

@sebastienros as part of #339 you put the Homepage settings UI in the autoroute module. This should really be in it's own module. Any reason why I shouldn't move it?

Edit: Actually if anything the homepage should probably be merged into autoroute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants