Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IEnumerable<IUserEventHandler> should not be called by UserDisplayDriver #17072

Open
MikeAlhayek opened this issue Nov 26, 2024 · 2 comments
Open
Milestone

Comments

@MikeAlhayek
Copy link
Member

I noticed that we resolve IEnumerable<IUserEventHandler> in UserDisplayDriver. I don't think this handler should by called by another hander like a display driver.

IEnumerable<IUserEventHandler> userEventHandlers,

We should be able to identify a user in Enable/Disabled from a controller or the user store instead of a driver.

@hishamco
Copy link
Member

hishamco commented Dec 4, 2024

@MikeAlhayek I'm working on a PR right now, I'm not sure why we introduced IEnumerable<IUserEventHandler> here

@sebastienros sebastienros added this to the 2.x milestone Dec 12, 2024
Copy link
Contributor

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants