Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL Breaks on Orchard Core Version 2.0.2 When Querying Multiple termContentItems #16883

Closed
vikasmahant69 opened this issue Oct 14, 2024 · 5 comments

Comments

@vikasmahant69
Copy link

Description

GraphQL queries involving termContentItems are breaking in Orchard Core version 2.0.2 when attempting to fetch multiple records, whereas these same queries were working as expected in version 1.8.3. This issue specifically arises when trying to fetch multiple records of termContentItems in relation to other properties.

Orchard Core version 2.0.2

To Reproduce

Steps to reproduce the behaviour:

  1. Create a GraphQL query fetching any contentItems and its termContentItems.
  2. The query breaks if multiple records for termContentItems are present.

Below is an example of a breaking query:
query MyQuery { exhibitor { name filterTags { termContentItems { displayText } } } }

Expected behavior

The query should return all records of termContentItems along with the associated name and filterTags for the exhibitor.

Additional Information

The query works fine when fetching only a single record. Example of a working query that limits the result set:

query MyQuery { exhibitor(first: 10) { name filterTags { termContentItems { displayText } } } }

Notes:

The issue did not exist in version 1.8.3, where the same query returned multiple records without any problem.
This suggests a regression or breaking change in version 2.0.2 that affects the handling of multiple termContentItems in GraphQL queries.

Potential Impact:

Users cannot reliably query multiple termContentItems in GraphQL.
This affects any Orchard Core instances that have upgraded from 1.8.3 to 2.0.2 and rely on similar GraphQL queries for their functionality.

Logs and screenshots

wbf-hohz-yfy.2024-10-07.14_46.GMT+1.mp4
@sebastienros
Copy link
Member

Extracted the stack trace

image

@sebastienros sebastienros added this to the 2.x milestone Oct 17, 2024
Copy link
Contributor

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

@gvkries
Copy link
Contributor

gvkries commented Nov 19, 2024

I quickly tried to reproduce this error with the blog theme, but it works flawlessly with the latest main. Could you share your content definitions?

Copy link
Contributor

github-actions bot commented Dec 4, 2024

It seems that this issue didn't really move for quite a while despite us asking the author for further feedback. Is this something you'd like to revisit any time soon or should we close? Please reply.

@github-actions github-actions bot added the stale label Dec 4, 2024
Copy link
Contributor

Closing this issue because it didn't receive further feedback from the author for very long. If you think this is still relevant, feel free to reopen it with the requested details.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2024
@MikeAlhayek MikeAlhayek modified the milestones: 2.x, 2.1.3, 2.1 Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants