Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated packages #15977

Closed
agriffard opened this issue May 5, 2024 · 6 comments · Fixed by #17027
Closed

Deprecated packages #15977

agriffard opened this issue May 5, 2024 · 6 comments · Fixed by #17027
Milestone

Comments

@agriffard
Copy link
Member

Warnings on some packages in Installed tab of Nuget packages in VS:

https://www.nuget.org/packages/NEST/7.17.5
Suggested Alternatives
Elastic.Clients.Elasticsearch

https://www.nuget.org/packages/Irony.Core/1.0.7
Suggested Alternatives
Irony

@hishamco
Copy link
Member

hishamco commented May 5, 2024

I notice that there's an issue with Irony.Core, so let us change the packages

@Skrypt what about NEST?

@hishamco
Copy link
Member

hishamco commented May 7, 2024

FYI the Irony.Core has been replaced with Irony in #16012

@hishamco
Copy link
Member

@Skrypt still waiting for your reply

@Skrypt
Copy link
Contributor

Skrypt commented Jun 18, 2024

No we can't replace NEST with the new Elasticsearch client without refactoring some parts of the Elasticsearch module. It will also remove support to some older versions of Elasticsearch so I see this upgrade as an OC.Elasticsearch 2.0 module. Meaning, we would need to keep the old module for those who want to still have support to older versions of Elasticsearch.

We launched the ES module when that new Elastic.Clients.Elasticsearch module was released so it should be around a year and a half that this new module exists. I think it adds support for ES 8.0 and up. NEST supports up to 8.0 in compatibility mode only.

@agriffard
Copy link
Member Author

It seems Irony.Core has been replaced.

@hishamco
Copy link
Member

Yes it is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants