Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto add Admin prefix only for Admin nodes. #13943

Closed
jtkech opened this issue Jul 4, 2023 · 0 comments · Fixed by #13944
Closed

Auto add Admin prefix only for Admin nodes. #13943

jtkech opened this issue Jul 4, 2023 · 0 comments · Fixed by #13944
Labels
bug 🐛
Milestone
1.7

Comments

@jtkech
Copy link
Member

jtkech commented Jul 4, 2023

We recently updated the NavigationManager so that admin menu items are auto prefixed by the AdminUrlPrefix option if not yet done, but as stated by @Piedone #12807 (comment), currently the auto admin prefixing should only be done for menu items built by the LinkAdminNodeNavigationBuilder.

This to not break people using the NavigationManager with other menu nodes but not for admin menus.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛
Projects
None yet
Milestone
1.7
Development

Successfully merging a pull request may close this issue.

Auto add Admin prefix only for Admin nodes. OrchardCMS/OrchardCore
2 participants
@sebastienros @jtkech