Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GraphiQL menu under Search #12710

Open
ns8482e opened this issue Oct 24, 2022 · 11 comments
Open

Move GraphiQL menu under Search #12710

ns8482e opened this issue Oct 24, 2022 · 11 comments

Comments

@ns8482e
Copy link
Contributor

ns8482e commented Oct 24, 2022

Is your feature request related to a problem? Please describe.

Move GraphiQL menu under parent menu Search. It's really a Search and not Configuration.

@Skrypt
Copy link
Contributor

Skrypt commented Oct 24, 2022

Well technically it is a Query not a Search.

@hishamco
Copy link
Member

Agree with @Skrypt, it's a query, we could add a new menu item if it's not there named Queries, then we could add GraphQL, SQL .. ect

@ns8482e
Copy link
Contributor Author

ns8482e commented Oct 24, 2022

Well technically it is a Query not a Search.

Currently Queries are under Search

@hishamco
Copy link
Member

I forgot that, seems that's why Niraj suggested that :)

@Skrypt
Copy link
Contributor

Skrypt commented Oct 24, 2022

Queries are either Search or SQL related this is why they are regrouped together. Wait before anything. Let's discuss about it.

@hishamco
Copy link
Member

Search requires query on some data store but I prefer to group search methodologies into a menu item called Search this should include Lucene, Elasticsearch, Azure Search .. etc. On other hand we need to have Queries which may include SQL, GraphQL .. etc

@ns8482e
Copy link
Contributor Author

ns8482e commented Oct 24, 2022

Queries on the other hand also saved into db to execute later

@MikeAlhayek
Copy link
Member

I agree with @ns8482e. It should not be under configurations. under "Search" is a good place for it since it's just another way to search contents. "Search" from user perspective is not only Lucene or Elastic search. I also think anything configuring the search engines should be moved under Configuration >> Search. Either way, placing GraphQL menu under "Search" make scene to me.

@MikeAlhayek
Copy link
Member

@Piedone @sebastienros thoughts on this?

@gvkries
Copy link
Contributor

gvkries commented Dec 4, 2024

I think the new "Tools" menu as suggested in #17112 makes even more sense than "search".

@Piedone
Copy link
Member

Piedone commented Dec 4, 2024

Agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants