From 6adce854a9909d1b6e447def9dbf8417ce7dda80 Mon Sep 17 00:00:00 2001 From: Pauline Auvray Date: Thu, 23 Nov 2023 09:46:19 +0100 Subject: [PATCH 1/2] [#710] Apply OdsPasswordTextField provided modifier on parent element --- .../component/textfield/password/OdsPasswordTextField.kt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/src/main/java/com/orange/ods/compose/component/textfield/password/OdsPasswordTextField.kt b/lib/src/main/java/com/orange/ods/compose/component/textfield/password/OdsPasswordTextField.kt index 007f1d08f..f0ea1638b 100644 --- a/lib/src/main/java/com/orange/ods/compose/component/textfield/password/OdsPasswordTextField.kt +++ b/lib/src/main/java/com/orange/ods/compose/component/textfield/password/OdsPasswordTextField.kt @@ -11,6 +11,7 @@ package com.orange.ods.compose.component.textfield.password import androidx.compose.foundation.layout.Column +import androidx.compose.foundation.layout.fillMaxWidth import androidx.compose.foundation.text.KeyboardActions import androidx.compose.foundation.text.KeyboardOptions import androidx.compose.material.Text @@ -85,11 +86,11 @@ fun OdsPasswordTextField( this.visualisationIcon.value = visualisationIcon } - Column { + Column(modifier = modifier) { OdsTextField( value = value, onValueChange = onValueChange, - modifier = modifier, + modifier = Modifier.fillMaxWidth(), enabled = enabled, readOnly = readOnly, label = label, From 474177a64ab003f3a056cf7d3e75c6aa0302bd08 Mon Sep 17 00:00:00 2001 From: Pauline Auvray Date: Thu, 23 Nov 2023 09:47:37 +0100 Subject: [PATCH 2/2] [#710] Update changelog --- changelog.md | 1 + 1 file changed, 1 insertion(+) diff --git a/changelog.md b/changelog.md index 804978114..b48d2378d 100644 --- a/changelog.md +++ b/changelog.md @@ -25,6 +25,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - \[App\] Fix nested class names in code implementation ([#708](https://github.com/Orange-OpenSource/ods-android/issues/708)) - \[Lib\] Fix back button color in `OdsLargeTopAppBar` ([#685](https://github.com/Orange-OpenSource/ods-android/issues/685)) +- \[Lib\] Fix a bug where the modifier was not taken into account in `OdsPasswordTextField` ([#710](https://github.com/Orange-OpenSource/ods-android/issues/710)) ## [0.17.0](https://github.com/Orange-OpenSource/ods-android/compare/0.16.0...0.17.0) - 2023-11-06