Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm installing from repo with #main #2469

Closed
3 tasks done
Dorian-Grim opened this issue Feb 6, 2024 · 0 comments
Closed
3 tasks done

npm installing from repo with #main #2469

Dorian-Grim opened this issue Feb 6, 2024 · 0 comments
Labels

Comments

@Dorian-Grim
Copy link

Prerequisites

Describe the issue

I am banging my head on the wall here, I can't figure this out. I am missing something but can't figure out what. So here's how it starts.

The repo has been update with #2223. So I want to benefit asap from the new code and I go ahead and do an npm install "https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap.git#main". Cli outputs it has updated my boosted package. When I npm start my app (react) and quickly change the <html> attribute data-bs-theme to dark, I see that it doesn't use the theme from the preview page

On my dev env I start investigating:

  1. inspect sources in node_modules
    when I go here, I see the changes being pulled from the repo. More exactly, I quickly check
    // Boosted mod: no --#{$prefix}alert-color
    and see if the line corresponds with the repo
  2. inspect sources in browser
    here however when I go to inspect, sources, open .\node_modules\boosted\scss\_alert.scss
    image

I say, ok, it's a cache problem. I start and remove every cache I can think of possible. From the browser and from npm. Whatever I do, browser code (line 81) is still not updated to #2223 code

At this point I'm thinking, ok, my env is messed up. I go make a fresh, vm, install windows on it and then:

  1. Install npm
  2. I run cd test-folder then run npx create-react-app my-app
  3. install boosted with https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap.git#main
  4. I go into my-app/node_modules/boosted/scss/_alert.scss line 81 to check the Dark mode #2223 mod. It is correct, desired code
  5. I open my-app/src/index.js
  6. I add import "boosted/dist/css/boosted.min.css"
  7. I run npm start
    app starts and opens
  8. I inspect in browser and go to sources .\node_modules\boosted\scss\_alert.scss
  9. Line 81 is not using new code 🤦‍♂️

I have literally no idea why, how, where it's fetching the old code from.

Please help with anything 🙏

Reduced test cases

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Chrome

What version of Boosted are you using?

5.3.2#main

@Dorian-Grim Dorian-Grim added the bug label Feb 6, 2024
@Orange-OpenSource Orange-OpenSource locked and limited conversation to collaborators Feb 6, 2024
@julien-deramond julien-deramond converted this issue into discussion #2470 Feb 6, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
Projects
None yet
Development

No branches or pull requests

1 participant