Add possibility to define disabled days #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvolkovich-sc
requested review from
estambakio-sc
and removed request for
asergeev-sc
| handleDayClick = (value, modifiers) => { | ||
| if (!modifiers.disabled) { | ||
| this.handleDateChange(value); | ||
| this.setState({ showPicker: false }); |
There was a problem hiding this comment.
Better be this.hidePicker(); instead.
| locale={'de'} | ||
| onChange={_scope.handleChange1.bind(_scope)} | ||
| value={_scope.state.value1} | ||
| disabledDays={{ after: new Date() }} |
There was a problem hiding this comment.
Props reference and example don't match: modifiers vs. disabledDays.
| @@ -32,7 +32,17 @@ See react-day-picker [methods reference](http://react-day-picker.js.org/APIMetho | |||
| <DayPicker | |||
| dayPickerRef={ref => (window.picker = ref)} | |||
| onChange={ day => console.log('day:', day) } | |||
| locale="de" | |||
| locale="en" | |||
| disabledDays={{ after: new Date() }} | |||
There was a problem hiding this comment.
Wrong naming? No such prop in prop types neither in component's code.
There was a problem hiding this comment.
No.
Changed to modifiers: { disabled: ... } Fixed.
| import './DayPicker.less'; | ||
| window.dayjs = dayjs; |
added 2 commits
August 23, 2018 15:48
| showPicker: false | ||
| }); | ||
| handleDayClick = (dayValue, modifiers) => { | ||
| if (!modifiers.disabled) { |
There was a problem hiding this comment.
Better
if (modifiers.disabled) {
return
}
... code
added 2 commits
August 23, 2018 15:56
estambakio-sc
approved these changes
Aug 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API changes
Added new property
modifiers.Implemented default
disabledmodifier.Disabled days validation and display for
DateInputandDateRangeInputcomponents can be implemented by validation at parent component level and passing validation result toisValidproperty.For validation use
import { ModifiersUtils } from @opuscapita/react-dates.See component documentation for details.