Migration from grpc to grpc-js

[xpirt]

I'm submitting a ...

• bug report
• feature request
• question about the decisions made in the repository
• question about how to use this project

Question

Hi there,
did you consider moving from grpc to grpc-js dependency? I think it is quite stable now to be used instead of the native dependency.

[avermeil]

Hi there!

What would be the advantages of using grpc-js rather than grpc?

Based on https://github.com/grpc/grpc-node/blob/master/PACKAGE-COMPARISON.md, it looks like grpc-js doesn't support the grpc.max_send_message_length or grpc.max_receive_message_length channel arguments, which we use in this lib. I'm not sure whether that information is still up to date...

[xpirt]

It seems grpc@grpc-js is now recommended instead of the native dependency by grpc authors. Mostly because of many compatibility issues on various platforms Node-based such as Electron (besides increasing considerably the size of the app).

For example, according to grpc/grpc-node#778 the native dependency has still some issues when run on non context-aware environments (because of nan dependency): grpc/grpc-node#778 (comment).

As @grpc-js is more mature, many developers (including Google with Firebase - issue: firebase/firebase-js-sdk#1783, PR: firebase/firebase-js-sdk#1804) are migrating/or have already migrated for the same issues.

[xpirt]

@avermeil As for the grpc.max_send_message_length and grpc.max_receive_message_length channel arguments, they have already been approved (grpc/grpc-node#1346) and being merged as we speak.
They are coming in 0.8.0 version.

Edit: merged.

[kritzware]

This is something we'll be working on soon 👍

[kritzware]

This is resolved now, and we recommend using google-ads-api which now supports Google Ads API v6.1.