Upgrading to React 16 - Implement Error Boundaries and Polyfills

[sethbergman]

Feature Update

#510 Needs additional, very simple fixes

React version 16 is fresh out of the master branch and the changelog notes some minor breaking changes.

Why is this feature being added?

Version 16 adds some great new functionality, but needs some love to get it upgraded safely.

---

Bug Report

• Implement polyfills in Jest.

  • requestAnimationFrame warning with React 16 jestjs/jest#4545 (comment)

• Implement polyfills for ES6 map and set.

  • https://github.com/facebook/react/blob/master/CHANGELOG.md#new-js-environment-requirements

• Implement polyfill for requestAnimationFrame

  • requestAnimationFrame warning with React 16 jestjs/jest#4545 (comment)

---

Implement Error Boundaries

https://reactjs.org/blog/2017/07/26/error-handling-in-react-16.html#introducing-error-boundaries

[sethbergman]

These changes shouldn't take more than an hour, with the exception of maybe the Error Boundaries. I'd need to understand the scope of their necessity, but if all is a go then by all means. Just at minimum do the requestAnimationFrame polyfill.

[jenniferabowd]

@sethbergman I am working on upgrading this to React 16.

[kylemh]

@jenniferkaplannyc @sethbergman is mid cherrypick on this issue - apologies.

We'd love to have you join our Slack team. Somebody of your calibre could be very useful on many of our issues.

[kylemh]

We need access to our CI/build process to debug the issues arising from implementing React 16 in production.

[sethbergman]

https://reactjs.org/blog/2017/09/26/react-v16.0.html#upgrading

[jenniferabowd]

I was having this same problem when I tried to upgrade your site, but then I saw the issue was closed so I deleted my files. However, were there any depreciation warnings in the previous version of React? If so, lets fix those to see if that resolves the issue when upgrading.

[sethbergman]

We're on 15.4, not 15.6 as it states in the article. There would need to be an upgrade to 15.6 first I believe.

[sethbergman]

But yes there were many peerDependencies that were giving warnings.

[sethbergman]

Linking this one here too: https://medium.com/ecmastack/what-you-need-to-know-about-react-16-a4e216522041

[jenniferabowd]

I think we should work through those first. If that is too time consuming then lets keep it on the current version of React.

…

On Oct 2, 2017, at 12:32 PM, Seth Bergman ***@***.***> wrote: But yes there were many peerDependencies that were giving warnings. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#532 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AWBNPZujJD9bf0qLYV156hjxz_t_vU2wks5soRAYgaJpZM4Pp9vN>.

[kylemh]

Perhaps a good next step would be to move to 15.6 to have more visibility on deprecation warnings.

[jenniferabowd]

Yes, that is a very good idea!

…

On Oct 2, 2017, at 12:35 PM, Kyle Holmberg ***@***.***> wrote: Perhaps a good next step would be to move to 15.6 to have more visibility on deprecation warnings. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#532 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AWBNPS-nM3H5GmlmYTr5a46nz7j5DFZ6ks5soRDQgaJpZM4Pp9vN>.

[sethbergman]

I agree wholeheartedly!

[kylemh]

@jenniferkaplannyc or @sethbergman feel free to grab #556

[sethbergman]

I'm about to take a nap. 👍

[AryanJ-NYC]

@sethbergman @kylemh Any hints on how to locally test if the shims and polyfills work correctly?

[kylemh]

I'm not sure why were not receiving dev warnings for dependencies, but I'm fairly certain that Storybook, React-Modal, and another few components have not yet made the move to React 16, thereby blocking this issue.

[jjhampton]

@kylemh Does this still need to be open? package.json shows that we're already on React v16 .

[kylemh]

@jjhampton nope