Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app-shell): fix electron-updater failures #17056

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Dec 6, 2024

Overview

In #17010, we lifted electron-updater out of several package.jsons into the monorepo package.json. So yeah...electron-builder builds using the sibling package.json, because of course, it can't really know what else it needs to pull into the build from any other package.json. Woops.

This PR effectively reverts that one commit in the linked PR.

Test Plan and Hands on Testing

  • Build locally (ex make -C app-shell dist-macos-latest). The build will still fail due to key signing, but the build will actually run.

Changelog

  • Fixed builds failing due to "Electron Updater" errors.

Risk assessment

low

@mjhuff mjhuff requested review from koji and sfoster1 December 6, 2024 18:20
@mjhuff mjhuff requested review from a team as code owners December 6, 2024 18:20
@mjhuff mjhuff changed the title fix(app): fix electron-updater failures fix(app-shell): fix electron-updater failures Dec 6, 2024
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes, sorry I didn't see this.

One interesting thing to note is that the ODD does not actually need this because it does not update itself, it only updates the robot. But it may be worth keeping just for the power of similarity.

@mjhuff mjhuff merged commit 67de4f4 into edge Dec 6, 2024
66 checks passed
@mjhuff mjhuff deleted the app-shell_fix-failing-builds branch December 6, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants