From 5625b9cddeb0ca934f86c443d992e357457c3f72 Mon Sep 17 00:00:00 2001 From: Jamey Huffnagle Date: Mon, 12 Aug 2024 13:47:35 -0400 Subject: [PATCH 1/2] fix(app): load natural pipetteId during error recovery --- .../DropTipWizardFlows/hooks/useDropTipCommands.ts | 5 +++-- .../DropTipWizardFlows/hooks/useDropTipWithType.ts | 7 ++++++- app/src/organisms/DropTipWizardFlows/types.ts | 1 + .../ErrorRecoveryFlows/RecoveryOptions/ManageTips.tsx | 10 ++++++++++ 4 files changed, 20 insertions(+), 3 deletions(-) diff --git a/app/src/organisms/DropTipWizardFlows/hooks/useDropTipCommands.ts b/app/src/organisms/DropTipWizardFlows/hooks/useDropTipCommands.ts index 44679342b82..9c35e0cbf84 100644 --- a/app/src/organisms/DropTipWizardFlows/hooks/useDropTipCommands.ts +++ b/app/src/organisms/DropTipWizardFlows/hooks/useDropTipCommands.ts @@ -334,12 +334,13 @@ const buildMoveToAACommand = ( export const buildLoadPipetteCommand = ( pipetteName: PipetteModelSpecs['name'], - mount: PipetteData['mount'] + mount: PipetteData['mount'], + pipetteId?: string | null ): CreateCommand => { return { commandType: 'loadPipette', params: { - pipetteId: MANAGED_PIPETTE_ID, + pipetteId: pipetteId ?? MANAGED_PIPETTE_ID, mount, pipetteName, }, diff --git a/app/src/organisms/DropTipWizardFlows/hooks/useDropTipWithType.ts b/app/src/organisms/DropTipWizardFlows/hooks/useDropTipWithType.ts index 33ea2a116fd..951b29c6266 100644 --- a/app/src/organisms/DropTipWizardFlows/hooks/useDropTipWithType.ts +++ b/app/src/organisms/DropTipWizardFlows/hooks/useDropTipWithType.ts @@ -117,10 +117,15 @@ function useRegisterPipetteFixitType({ instrumentModelSpecs, issuedCommandsType, chainRunCommands, + fixitCommandTypeUtils, }: UseRegisterPipetteFixitType): void { React.useEffect(() => { if (issuedCommandsType === 'fixit') { - const command = buildLoadPipetteCommand(instrumentModelSpecs.name, mount) + const command = buildLoadPipetteCommand( + instrumentModelSpecs.name, + mount, + fixitCommandTypeUtils?.pipetteId + ) void chainRunCommands([command], true) } }, []) diff --git a/app/src/organisms/DropTipWizardFlows/types.ts b/app/src/organisms/DropTipWizardFlows/types.ts index 15a9e25cc9e..4238d9ac8a0 100644 --- a/app/src/organisms/DropTipWizardFlows/types.ts +++ b/app/src/organisms/DropTipWizardFlows/types.ts @@ -36,6 +36,7 @@ export interface DropTipWizardRouteOverride { export interface FixitCommandTypeUtils { runId: string failedCommandId: string + pipetteId: string | null copyOverrides: CopyOverrides errorOverrides: ErrorOverrides buttonOverrides: ButtonOverrides diff --git a/app/src/organisms/ErrorRecoveryFlows/RecoveryOptions/ManageTips.tsx b/app/src/organisms/ErrorRecoveryFlows/RecoveryOptions/ManageTips.tsx index 58999c0cabb..cc82e3b2334 100644 --- a/app/src/organisms/ErrorRecoveryFlows/RecoveryOptions/ManageTips.tsx +++ b/app/src/organisms/ErrorRecoveryFlows/RecoveryOptions/ManageTips.tsx @@ -24,6 +24,7 @@ import { DropTipWizardFlows } from '../../DropTipWizardFlows' import { DT_ROUTES } from '../../DropTipWizardFlows/constants' import { SelectRecoveryOption } from './SelectRecoveryOption' +import type { PipettingRunTimeCommand } from '@opentrons/shared-data' import type { PipetteWithTip } from '../../DropTipWizardFlows' import type { RecoveryContentProps, RecoveryRoute, RouteStep } from '../types' import type { FixitCommandTypeUtils } from '../../DropTipWizardFlows/types' @@ -200,6 +201,7 @@ export function useDropTipFlowUtils({ subMapUtils, routeUpdateActions, recoveryMap, + failedPipetteInfo, }: RecoveryContentProps): FixitCommandTypeUtils { const { t } = useTranslation('error_recovery') const { @@ -301,9 +303,17 @@ export function useDropTipFlowUtils({ } } + const pipetteId = + failedCommand != null && + 'params' in failedCommand.byRunRecord && + 'pipetteId' in failedCommand.byRunRecord.params + ? failedCommand.byRunRecord.params.pipetteId + : null + return { runId, failedCommandId, + pipetteId, copyOverrides: buildCopyOverrides(), errorOverrides: buildErrorOverrides(), buttonOverrides: buildButtonOverrides(), From 086b43fe70ac9d770e81114827b581dccdd517cd Mon Sep 17 00:00:00 2001 From: Jamey Huffnagle Date: Mon, 12 Aug 2024 14:59:30 -0400 Subject: [PATCH 2/2] lint --- .../organisms/ErrorRecoveryFlows/RecoveryOptions/ManageTips.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/app/src/organisms/ErrorRecoveryFlows/RecoveryOptions/ManageTips.tsx b/app/src/organisms/ErrorRecoveryFlows/RecoveryOptions/ManageTips.tsx index cc82e3b2334..f79f0a7bc76 100644 --- a/app/src/organisms/ErrorRecoveryFlows/RecoveryOptions/ManageTips.tsx +++ b/app/src/organisms/ErrorRecoveryFlows/RecoveryOptions/ManageTips.tsx @@ -24,7 +24,6 @@ import { DropTipWizardFlows } from '../../DropTipWizardFlows' import { DT_ROUTES } from '../../DropTipWizardFlows/constants' import { SelectRecoveryOption } from './SelectRecoveryOption' -import type { PipettingRunTimeCommand } from '@opentrons/shared-data' import type { PipetteWithTip } from '../../DropTipWizardFlows' import type { RecoveryContentProps, RecoveryRoute, RouteStep } from '../types' import type { FixitCommandTypeUtils } from '../../DropTipWizardFlows/types'