From ca99b0bcc74f8059eecf021d0d6c63ed1f87434d Mon Sep 17 00:00:00 2001 From: Seth Foster Date: Fri, 7 Jun 2024 12:59:51 -0400 Subject: [PATCH 1/5] chore: reenable storybook pushes for all branches This was removed in 3c4008d38 and shouldn't have been. --- .github/workflows/components-test-build-deploy.yaml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/components-test-build-deploy.yaml b/.github/workflows/components-test-build-deploy.yaml index d714b198232..7c1c158f705 100644 --- a/.github/workflows/components-test-build-deploy.yaml +++ b/.github/workflows/components-test-build-deploy.yaml @@ -114,15 +114,18 @@ jobs: steps: - id: determine-build-type run: | - echo "Determining build type for event ${{github.event_type}} and ref ${{github.ref}}" - if [ "${{ format('{0}', github.ref == 'refs/heads/edge') }}" = "true" ] ; then + echo "Determining build type for event ${{github.event_name}} and ref ${{github.ref}}" + if [ "${{ format('{0}', github.event_name == 'pull_request' }}" = "true" ] ; + echo "No builds for pull requests" + echo 'type=none' >> $GITHUB_OUTPUT + elif [ "${{ format('{0}', startsWith(github.ref, 'refs/heads/') }}" = "true" ] ; then echo "storybook s3 builds for edge" echo 'type=storybook' >> $GITHUB_OUTPUT elif [ "${{ format('{0}', startsWith(github.ref, 'refs/tags/components')) }}" = "true" ] ; then echo "publish builds for components tags" echo 'type=publish' >> $GITHUB_OUTPUT else - echo "No build for ref ${{github.ref}} and event ${{github.event_type}}" + echo "No build for ref ${{github.ref}} and event ${{github.event_name}}" echo 'type=none' >> $GITHUB_OUTPUT fi From 815a6cafc3658381cc3e9c5f8b90a60d69ba5463 Mon Sep 17 00:00:00 2001 From: Seth Foster Date: Fri, 7 Jun 2024 13:04:21 -0400 Subject: [PATCH 2/5] whoops --- .github/workflows/components-test-build-deploy.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/components-test-build-deploy.yaml b/.github/workflows/components-test-build-deploy.yaml index 7c1c158f705..8e4ef90f86c 100644 --- a/.github/workflows/components-test-build-deploy.yaml +++ b/.github/workflows/components-test-build-deploy.yaml @@ -115,7 +115,7 @@ jobs: - id: determine-build-type run: | echo "Determining build type for event ${{github.event_name}} and ref ${{github.ref}}" - if [ "${{ format('{0}', github.event_name == 'pull_request' }}" = "true" ] ; + if [ "${{ format('{0}', github.event_name == 'pull_request') }}" = "true" ] ; echo "No builds for pull requests" echo 'type=none' >> $GITHUB_OUTPUT elif [ "${{ format('{0}', startsWith(github.ref, 'refs/heads/') }}" = "true" ] ; then From 2c0d845656c5066a8dbe8cf8e540222646803750 Mon Sep 17 00:00:00 2001 From: Seth Foster Date: Fri, 7 Jun 2024 13:06:40 -0400 Subject: [PATCH 3/5] one more --- .github/workflows/components-test-build-deploy.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/components-test-build-deploy.yaml b/.github/workflows/components-test-build-deploy.yaml index 8e4ef90f86c..e2512f270da 100644 --- a/.github/workflows/components-test-build-deploy.yaml +++ b/.github/workflows/components-test-build-deploy.yaml @@ -118,7 +118,7 @@ jobs: if [ "${{ format('{0}', github.event_name == 'pull_request') }}" = "true" ] ; echo "No builds for pull requests" echo 'type=none' >> $GITHUB_OUTPUT - elif [ "${{ format('{0}', startsWith(github.ref, 'refs/heads/') }}" = "true" ] ; then + elif [ "${{ format('{0}', startsWith(github.ref, 'refs/heads/')) }}" = "true" ] ; then echo "storybook s3 builds for edge" echo 'type=storybook' >> $GITHUB_OUTPUT elif [ "${{ format('{0}', startsWith(github.ref, 'refs/tags/components')) }}" = "true" ] ; then From efd514cdbb4f6e7c3e745c6165edc4f2f5133b86 Mon Sep 17 00:00:00 2001 From: Seth Foster Date: Fri, 7 Jun 2024 13:09:55 -0400 Subject: [PATCH 4/5] aah --- .github/workflows/components-test-build-deploy.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/components-test-build-deploy.yaml b/.github/workflows/components-test-build-deploy.yaml index e2512f270da..1ca0ef89b2c 100644 --- a/.github/workflows/components-test-build-deploy.yaml +++ b/.github/workflows/components-test-build-deploy.yaml @@ -115,7 +115,7 @@ jobs: - id: determine-build-type run: | echo "Determining build type for event ${{github.event_name}} and ref ${{github.ref}}" - if [ "${{ format('{0}', github.event_name == 'pull_request') }}" = "true" ] ; + if [ "${{ format('{0}', github.event_name == 'pull_request') }}" = "true" ] ; then echo "No builds for pull requests" echo 'type=none' >> $GITHUB_OUTPUT elif [ "${{ format('{0}', startsWith(github.ref, 'refs/heads/')) }}" = "true" ] ; then From 6ab16d3a9b1e0d9cc0e209c2943b7e8ef7a7faa9 Mon Sep 17 00:00:00 2001 From: Seth Foster Date: Fri, 7 Jun 2024 13:13:03 -0400 Subject: [PATCH 5/5] nicer log --- .github/workflows/components-test-build-deploy.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/components-test-build-deploy.yaml b/.github/workflows/components-test-build-deploy.yaml index 1ca0ef89b2c..38c30c400a2 100644 --- a/.github/workflows/components-test-build-deploy.yaml +++ b/.github/workflows/components-test-build-deploy.yaml @@ -119,7 +119,7 @@ jobs: echo "No builds for pull requests" echo 'type=none' >> $GITHUB_OUTPUT elif [ "${{ format('{0}', startsWith(github.ref, 'refs/heads/')) }}" = "true" ] ; then - echo "storybook s3 builds for edge" + echo "storybook s3 builds for branch ${{ github.ref_name }}" echo 'type=storybook' >> $GITHUB_OUTPUT elif [ "${{ format('{0}', startsWith(github.ref, 'refs/tags/components')) }}" = "true" ] ; then echo "publish builds for components tags"