Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix border radius Storybook #14698

Merged
merged 2 commits into from
Mar 20, 2024
Merged

fix(app): fix border radius Storybook #14698

merged 2 commits into from
Mar 20, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented Mar 19, 2024

Overview

fix border radius storybook

close AUTH-223

Test Plan

Run make -C components dev and click border radius storybook.
check the latest border radius values show up.

Changelog

  • update border radius storybook

Review requests

Risk assessment

low

fix border radius storybook

close AUTH-223
@koji koji requested review from mjhuff and a team March 19, 2024 22:20
@koji koji marked this pull request as ready for review March 19, 2024 22:20
@koji koji requested a review from a team as a code owner March 19, 2024 22:20
@koji koji removed the request for review from a team March 19, 2024 22:20
const bValue = parseInt(b[1])
return aValue - bValue
})
console.log(targetBorderRadiuses)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgotten console log?

Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment but lgtm

Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@koji koji merged commit 5ecd1a4 into edge Mar 20, 2024
20 checks passed
@koji koji deleted the fix_border-radius-storybook branch March 20, 2024 14:02
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
* fix(app): fix border radius Storybook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants