Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(engine): execute a thermocycler profile #9559

Closed
2 tasks
mcous opened this issue Feb 24, 2022 · 1 comment · Fixed by #10921
Closed
2 tasks

feat(engine): execute a thermocycler profile #9559

mcous opened this issue Feb 24, 2022 · 1 comment · Fixed by #10921
Assignees
@shlokamin @jbleon95
Labels
json-v6 Issues related to JSON Protocol Schema v6 protocol-engine Ticket related to the Protocol Engine project and associated HTTP APIs robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).

Comments

@mcous
Copy link
Contributor

mcous commented Feb 24, 2022 •
edited
Loading

Overview

As a Protocol Designer user, I'd like to command my thermocycler to execute a temperature profile when using the latest version of Protocol Designer, which outputs JSON Protocol Schema v6.

Acceptance criteria

  • thermocycler/runProfile command supported by JSON v6 and HTTP run commands
    • Since it's a long running blocking command, it should not be supported by live POST /commands
  • thermocycler/runProfile takes three parameters
    • moduleId - The engine ID of the module
    • profile - An array of profile step objest with fields
      • celsius - The target temperature of the step
      • holdSeconds - The time to hold at the target for the step
    • blockMaxVolumeUl - Amount of liquid in the most-full well in the thermocycler

Implementation notes

  • The command should be fully blocking
  • The JSONv6 schema for runProfile needs its names for various parameters changed to match the criteria above
    • volume > blockMaxVolumeUl
    • profile.temperature > profile.celsius
    • profile.holdTime > profile.holdSeconds

Other than those notes above, the best resource for implementing this command is the existing PAPIv2 implementation, similar to the other module commands we've implemented
@mcous mcous added robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). protocol-engine Ticket related to the Protocol Engine project and associated HTTP APIs papi-v3 labels Feb 24, 2022
@mcous mcous added the WIP label Mar 3, 2022
@mcous mcous self-assigned this Jun 17, 2022
@mcous mcous changed the title PAPIv3: execute thermocycler profile feat(engine): execute a thermocycler profile Jun 17, 2022
@mcous mcous added json-v6 Issues related to JSON Protocol Schema v6 and removed papi-v3 WIP labels Jun 17, 2022
@shlokamin shlokamin self-assigned this Jun 17, 2022
@mcous
Copy link
Contributor Author

mcous commented Jun 17, 2022

Moved PAPIv3 concerns out of this ticket and into #10833

@mcous mcous removed their assignment Jun 17, 2022
@jbleon95 jbleon95 self-assigned this Jun 27, 2022
@jbleon95 jbleon95 mentioned this issue Jun 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shlokamin shlokamin

@jbleon95 jbleon95

Labels
json-v6 Issues related to JSON Protocol Schema v6 protocol-engine Ticket related to the Protocol Engine project and associated HTTP APIs robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(engine): thermocycler run profile Opentrons/opentrons
3 participants
@mcous @shlokamin @jbleon95