Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robot Server: Remove wsproto workaround #8266

Closed
2 tasks
mcous opened this issue Aug 27, 2021 · 0 comments
Closed
2 tasks

Robot Server: Remove wsproto workaround #8266

mcous opened this issue Aug 27, 2021 · 0 comments
Labels
chore Robot Tech Debt For review in robot guild meetings robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).

Comments

@mcous
Copy link
Contributor

mcous commented Aug 27, 2021

Overview

In #6229, we switched our websockets library from the uvicorn default of websockets to wsproto, because uvicorn did not allow configuration of websocket's default 1 MB message size, whereas wsproto has no maximum message size. JSON protocols are often larger than 1 MB, so the hardcoded message limit was untenable. An unlimited message size, however, isn't great either!

As of uvicorn v0.14, the message limit for websockets has been made configurable and set to a default of 16 MB. Now that #8228 has upgraded uvicorn to v0.14, we should remove our wsproto workaround.

Advantages of websockets:

  • A default, configurable message limit is safer than no limit
  • wsproto doesn't appear to be under super active development
  • Using uvicorn's default websockets library will likely have better long term support from uvicorn devs

Acceptance criteria

  • wsproto removed as a robot-server dependency
  • wsproto removed as a buildroot dependency (TODO: create Opentrons/buildroot ticket)
@mcous mcous added robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). Robot Tech Debt For review in robot guild meetings labels Aug 27, 2021
@mcous mcous closed this as not planned Won't fix, can't repro, duplicate, stale Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Robot Tech Debt For review in robot guild meetings robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
Projects
None yet
Development

No branches or pull requests

2 participants