fix(api): fix module path for jupyter notebook #8009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## edge #8009 +/- ##
=======================================
Coverage ? 85.88%
=======================================
Files ? 348
Lines ? 21254
Branches ? 0
=======================================
Hits ? 18253
Misses ? 3001
Partials ? 0 Continue to review full report at Codecov.
|
amitlissack
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #7959. We should use the absolute path for modules, otherwise jupyter notebook will not be able to find the correct port to connect to the module.
Changelog
dev/ot_module*to/dev/ot_module*Review requests
Pls make sure this didn't break anything. Run module protocol in the app and also in jupyter notebook. Disconnect/Reconnect modules a few times.
Risk assessment
Medium.