-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): allow labware calibration on non liquid handling events #7812
Conversation
Codecov Report
@@ Coverage Diff @@
## edge #7812 +/- ##
===========================================
- Coverage 93.56% 83.48% -10.09%
===========================================
Files 116 333 +217
Lines 4774 21243 +16469
===========================================
+ Hits 4467 17735 +13268
- Misses 307 3508 +3201
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this feature. Code looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Overview.
Closes #7800. In certain applications, a user may want to simply move to a labware with their pipette. In our current system, this means they cannot calibrate that labware until they either add a liquid handling command or they create a whole separate 'calibration' protocol.
Changelog
move_to
in both a regular instrument context and a paired instrument contextReview requests
Test on a robot. Have a robot move to a labware only, and you should be able to calibrate that labware now
Risk assessment
Low. Simply adding the ability to calibrate extra labware in a protocol. Right now, users have to create a separate protocol or do fake aspirate/dispenses in order to calibrate labware that is only moved to.