Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): allow labware calibration on non liquid handling events #7812

Merged
merged 2 commits into from
May 17, 2021

Conversation

Laura-Danielle
Copy link
Contributor

Overview.

Closes #7800. In certain applications, a user may want to simply move to a labware with their pipette. In our current system, this means they cannot calibrate that labware until they either add a liquid handling command or they create a whole separate 'calibration' protocol.

Changelog

  • Add a run log for move_to in both a regular instrument context and a paired instrument context
  • Add a test to check that the session does indeed save that labware
  • Update relevant types

Review requests

Test on a robot. Have a robot move to a labware only, and you should be able to calibrate that labware now

Risk assessment

Low. Simply adding the ability to calibrate extra labware in a protocol. Right now, users have to create a separate protocol or do fake aspirate/dispenses in order to calibrate labware that is only moved to.

@Laura-Danielle Laura-Danielle added feature Ticket is a feature request / PR introduces a feature api Affects the `api` project labels May 13, 2021
@Laura-Danielle Laura-Danielle requested review from a team May 13, 2021 19:06
@Laura-Danielle Laura-Danielle requested a review from a team as a code owner May 13, 2021 19:06
@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #7812 (e0c13a4) into edge (ccfd044) will decrease coverage by 10.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             edge    #7812       +/-   ##
===========================================
- Coverage   93.56%   83.48%   -10.09%     
===========================================
  Files         116      333      +217     
  Lines        4774    21243    +16469     
===========================================
+ Hits         4467    17735    +13268     
- Misses        307     3508     +3201     
Impacted Files Coverage Δ
opentrons/commands/helpers.py 86.36% <0.00%> (ø)
opentrons/protocol_engine/commands/command.py 95.91% <0.00%> (ø)
...rotocols/context/protocol_api/paired_instrument.py 85.60% <0.00%> (ø)
opentrons/protocols/execution/dev_types.py 0.00% <0.00%> (ø)
opentrons/drivers/types.py 100.00% <0.00%> (ø)
...ns/protocol_api_experimental/instrument_context.py 100.00% <0.00%> (ø)
opentrons/protocol_api/contexts.py 100.00% <0.00%> (ø)
opentrons/motion_planning/waypoints.py 100.00% <0.00%> (ø)
...protocols/context/protocol_api/protocol_context.py 90.84% <0.00%> (ø)
opentrons/protocol_engine/state/pipettes.py 98.61% <0.00%> (ø)
... and 207 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccfd044...e0c13a4. Read the comment docs.

Copy link
Contributor

@ahiuchingau ahiuchingau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this feature. Code looks good to me!

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Copy link

@nusrat813 nusrat813 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laura-Danielle Laura-Danielle merged commit 26567f4 into edge May 17, 2021
@Laura-Danielle Laura-Danielle deleted the refactor_allow_calibration_with_move_to branch May 17, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Affects the `api` project feature Ticket is a feature request / PR introduces a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add ability to calibrate labware when not using a liquid handling command on a labware
4 participants