fix(app): Filter pipette offset calibrations by mount as well #7017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laura-Danielle
requested review from
ahiuchingau and
b-cooper
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Previously, the app only filtered pipette calibrations by the pipette serial number/robot. However, if you calibrated a pipette on the right mount and then switched it to the left mount the app would display calibration data for the right mount.
Changelog
Review requests
Calibrate a pipette on one mount, and then switch that same pipette to the other mount (where there is no calibration data). It should say you need to calibrate that pipette rather than showing data from the previously calibrated mount.
Risk assessment
Low, bug fix to filter out pipette calibrations properly.