Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): fix required modules list on protocol info page #7012

Merged
merged 1 commit into from
Nov 16, 2020
Merged

fix(app): fix required modules list on protocol info page #7012

merged 1 commit into from
Nov 16, 2020

Conversation

b-cooper
Copy link
Contributor

Overview

Remove reference to calibration data in required modules list on protoco info page, replace it with
helpful text to emphasize that a module is not attached, in the same manner as the pipettes list

Changelog

  • the require modules section was erroneously using the InstrumentItem component for each module in the list, which has pipette specific functionality in it. Instead cop the parts of that component that we want to keep and inline them in the ProtocolModulesCard iteration

Review requests

  • upload a protocol with modules, some attached and some not. Should never see info about any kind of calibration in the Required Modules section of the protocol info page.

Risk assessment

low

@b-cooper
fix(app): fix required modules list on protocol info page
10cd183 
Remove reference to calibration data in required modules list on protoco info page, replace it with
helpful text to emphasize that a module is not attached, in the same manner as the pipettes list
@b-cooper b-cooper added app Affects the `app` project hmg hardware, motion, and geometry labels Nov 16, 2020
@b-cooper b-cooper added this to the HMG Sprint 22 milestone Nov 16, 2020
@b-cooper b-cooper requested review from a team November 16, 2020 23:05
@b-cooper b-cooper requested a review from a team as a code owner November 16, 2020 23:05
@b-cooper b-cooper requested review from ahiuchingau and IanLondon and removed request for a team November 16, 2020 23:05
sfoster1
sfoster1 approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

nusrat813
nusrat813 approved these changes Nov 16, 2020
View reviewed changes
Copy link

@nusrat813 nusrat813 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested - working as intended

@b-cooper b-cooper merged commit 47fdbb5 into chore_release-4.0.0-beta.0 Nov 16, 2020
@b-cooper b-cooper deleted the app_fix-protocol-info-modules-list branch November 16, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nusrat813 nusrat813 nusrat813 approved these changes

@sfoster1 sfoster1 sfoster1 approved these changes

@ahiuchingau ahiuchingau Awaiting requested review from ahiuchingau

@IanLondon IanLondon Awaiting requested review from IanLondon

Assignees
No one assigned
Labels
app Affects the `app` project hmg hardware, motion, and geometry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@b-cooper @sfoster1 @nusrat813