Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): prettyprint cal check results #6964

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

sfoster1
Copy link
Member

Now that we're not showing the results data in the cal check summary
screen anymore, it's more likely that users will want to look at the
check report, so let's pretty print it so they can read it without
putting it into an externnal formatter or something.

{
    "comparisonsByPipette": {
        "first": {
            "tipLength": {
                "status": "IN_THRESHOLD",
                "comparingTip": {
                    "differenceVector": [
                        0,
                        0,
                        0
                    ],
                    "thresholdVector": [
                        0,
                        0,
                        0.27
                    ],
                    "exceedsThreshold": false
                }
            },
            "pipetteOffset": {
                "status": "IN_THRESHOLD",
                "comparingHeight": {
                    "differenceVector": [
                        0,
                        10,
                        0
                    ],
                    "thresholdVector": [
                        0,
                        0,
                        1
                    ],
                    "exceedsThreshold": false
                },
                "comparingPointOne": {
                    "differenceVector": [
                        -1,
                        0,
                        0
                    ],
                    "thresholdVector": [
                        2.7,
                        2.7,
                        0
                    ],
                    "exceedsThreshold": false
                }
            },
            "deck": {
                "status": "IN_THRESHOLD",
                "comparingPointOne": {
                    "differenceVector": [
                        -1,
                        0,
                        0
                    ],
                    "thresholdVector": [
                        2.7,
                        2.7,
                        0
                    ],
                    "exceedsThreshold": false
                },
                "comparingPointTwo": {
                    "differenceVector": [
                        -2,
                        0,
                        0
                    ],
                    "thresholdVector": [
                        2.7,
                        2.7,
                        0
                    ],
                    "exceedsThreshold": false
                },
                "comparingPointThree": {
                    "differenceVector": [
                        -2,
                        0,
                        0
                    ],
                    "thresholdVector": [
                        2.7,
                        2.7,
                        0
                    ],
                    "exceedsThreshold": false
                }
            }
        },
        "second": {
            "tipLength": null,
            "pipetteOffset": null,
            "deck": null
        }
    },
    "instruments": [
        {
            "model": "p1000_single_v2.0",
            "name": "p1000_single_gen2",
            "tipLength": 78.3,
            "mount": "LEFT",
            "serial": "P1KSV202019072443",
            "rank": "first",
            "tipRackLoadName": "opentrons_96_tiprack_1000ul",
            "tipRackDisplay": "Opentrons 96 Tip Rack 1000 µL",
            "tipRackUri": "opentrons/opentrons_96_tiprack_1000ul/1"
        }
    ],
    "savedAt": "2020-11-10T22:45:23.743Z"
}

Now that we're not showing the results data in the cal check summary
screen anymore, it's more likely that users will want to look at the
check report, so let's pretty print it so they can read it without
putting it into an externnal formatter or something.
@sfoster1 sfoster1 added app Affects the `app` project fix PR fixes a bug labels Nov 10, 2020
@sfoster1 sfoster1 added this to the HMG Sprint 22 milestone Nov 10, 2020
@sfoster1 sfoster1 requested a review from a team November 10, 2020 22:49
@sfoster1 sfoster1 requested a review from a team as a code owner November 10, 2020 22:49
@sfoster1 sfoster1 requested review from ahiuchingau and IanLondon and removed request for a team November 10, 2020 22:49
Copy link
Contributor

@Laura-Danielle Laura-Danielle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay

@sfoster1 sfoster1 merged commit 8ebb9f7 into chore_release-4.0.0-beta.0 Nov 10, 2020
@sfoster1 sfoster1 deleted the app_prettify-calcheck-results branch November 10, 2020 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project fix PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants