fix(app): suppress title bar exit in calcheck results #6941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And also remove the unused parts (like 90%) of styles.css in the calcheck hierarchy.
b-cooper
reviewed
Nov 6, 2020
| back: { | ||
| onClick: confirmExit, | ||
| title: EXIT, | ||
| children: EXIT, |
There was a problem hiding this comment.
if you wanted to completely get rid of the styles.css file you could replace the className with a dummy box e.g.
back: currentStep === Sessions.CHECK_STEP_RESULTS_SUMMARY ? {title: null, children: (<Box width={SIZE_1} />)} : {...}
There was a problem hiding this comment.
I think I tried that in some other case and it had some display issues around active-state rendering. I think we should just keep the styles thing until that's a styled-component or primitive and we can use a css literal or something
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also remove the unused parts (like 90%) of styles.css in the
calcheck hierarchy.
Note: I haven't tested this yet