Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): remove redundant tip rack display name from tooltip #6770

Merged
merged 2 commits into from
Oct 15, 2020

Conversation

b-cooper
Copy link
Contributor

Overview

In the calibration tab, the new list items for tip racks per mount still had the old tooltip that shows the displayName and the name of the tip rack protocol labware. Because the displayName is now in the list item itself. We can remove it from the tool tip.

Changelog

  • remove displayName from tiprack list item tool tip
  • update tool tip to use new Tooltip and useHoverTooltip utilities over the deprecated HoverTooltip component

Review requests

Make sure that the tool tip looks right for tip rack list items in the calibration tab.

Risk assessment

very low

@b-cooper b-cooper requested a review from a team as a code owner October 14, 2020 20:00
@b-cooper b-cooper requested review from mcous and removed request for a team October 14, 2020 20:00
@b-cooper b-cooper added fix PR fixes a bug hmg hardware, motion, and geometry labels Oct 14, 2020
@b-cooper b-cooper requested review from a team and Laura-Danielle and removed request for a team October 14, 2020 20:00
Copy link
Contributor

@ahiuchingau ahiuchingau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ahiuchingau ahiuchingau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ ✅ ✅

@b-cooper b-cooper merged commit a81228a into edge Oct 15, 2020
@b-cooper b-cooper deleted the app_tooltip-too-extra branch October 15, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix PR fixes a bug hmg hardware, motion, and geometry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants