fix(app): make tip length calibration use generic calibration command #6489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-cooper
requested review from
mcous,
a team and
ahiuchingau
and removed request for
a team
b-cooper
added
app
ahiuchingau
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The moveToTipRack command was moved up into the generic calibration session command scope, but this instance was not updated, which caused the tip calibration flow to stop before grabbing the tip.
Changelog
Switch out the command string for the moveToTipRack command for the generically scoped calibration session command.
Review requests
Ensure you can run through tip length calibration
Risk assessment
Low, very small change