-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app): add Jupyter Notebook button to robot's Advanced Settings #6474
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. And so does the video!
Shuffling some stuff around based on UX and support feedback. Should be ready for review again later today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the vid otherwise I wouldn't have found the button!
code looks good but I don't have a robot so can only do api dev server. With that, http://localhost:48888/
isn't running jupyter. Obvs non-blocking and I guess api dev server doesn't run a jupyter server too so that's expected?
Codecov Report
@@ Coverage Diff @@
## edge #6474 +/- ##
=======================================
Coverage ? 80.18%
=======================================
Files ? 236
Lines ? 20127
Branches ? 0
=======================================
Hits ? 16138
Misses ? 3989
Partials ? 0
Continue to review full report at Codecov.
|
Copy + placement approval from Support + UX via 👍's in Slack |
Overview
This PR adds a button to open an OT-2's Jupyter Notebook in a web browser to the "Robot Controls" card in the robot settings page.
Copy reads:
Closes #6102
Changelog
jupyterOpen
analytics eventReview requests
Risk assessment
Low. Good unit test coverage