Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): add Jupyter Notebook button to robot's Advanced Settings #6474

Merged
merged 4 commits into from
Sep 9, 2020

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Sep 2, 2020

Overview

This PR adds a button to open an OT-2's Jupyter Notebook in a web browser to the "Robot Controls" card in the robot settings page.

2020-09-09 12 19 18

Copy reads:

Jupyter Notebook

Open the Jupyter Notebook running on this OT-2 in your web browser. (Experimental feature! See documentation for more details.)

Closes #6102

Changelog

  • feat(app): add Jupyter Notebook button to Robot Controls
    • Clicking the button will send a jupyterOpen analytics event

Review requests

  1. Open the Robot's page
  2. Click the "Open" button next to "Open Jupyter Notebook"
  3. Browser should open to Jupyter Notebook
    • Note: this will only work with a real robot / RPi that's serving Jupyter on port 48888

Risk assessment

Low. Good unit test coverage

@mcous mcous added feature Ticket is a feature request / PR introduces a feature ready for review ux review required robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). labels Sep 2, 2020
@mcous mcous requested a review from a team as a code owner September 2, 2020 16:28
@mcous mcous requested review from IanLondon, a team, amitlissack and sanni-t and removed request for a team September 2, 2020 16:28
Copy link
Contributor

@amitlissack amitlissack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. And so does the video!

@mcous mcous added WIP and removed ready for review labels Sep 3, 2020
@mcous
Copy link
Contributor Author

mcous commented Sep 3, 2020

Shuffling some stuff around based on UX and support feedback. Should be ready for review again later today

Copy link
Contributor

@IanLondon IanLondon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the vid otherwise I wouldn't have found the button!

code looks good but I don't have a robot so can only do api dev server. With that, http://localhost:48888/ isn't running jupyter. Obvs non-blocking and I guess api dev server doesn't run a jupyter server too so that's expected?

@mcous mcous added ready for review and removed WIP labels Sep 9, 2020
@codecov
Copy link

codecov bot commented Sep 9, 2020

Codecov Report

❗ No coverage uploaded for pull request base (edge@4e67e31). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge    #6474   +/-   ##
=======================================
  Coverage        ?   80.18%           
=======================================
  Files           ?      236           
  Lines           ?    20127           
  Branches        ?        0           
=======================================
  Hits            ?    16138           
  Misses          ?     3989           
  Partials        ?        0           
Impacted Files Coverage Δ
opentrons/hardware_control/modules/types.py 95.83% <0.00%> (ø)
opentrons/drivers/serial_communication.py 28.57% <0.00%> (ø)
...obot-server/robot_server/service/session/router.py 100.00% <0.00%> (ø)
opentrons/util/logging_config.py 87.50% <0.00%> (ø)
opentrons/hardware_control/modules/__init__.py 100.00% <0.00%> (ø)
.../robot_server/service/legacy/routers/networking.py 98.52% <0.00%> (ø)
...rver/robot_server/robot/calibration/deck/models.py 100.00% <0.00%> (ø)
opentrons/util/calibration_functions.py 100.00% <0.00%> (ø)
...ce/session/command_execution/base_command_queue.py 61.53% <0.00%> (ø)
...rver/robot/calibration/pipette_offset/constants.py 94.44% <0.00%> (ø)
... and 226 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e67e31...097bd60. Read the comment docs.

@mcous mcous changed the title feat(app): add Jupyter Notebook button to Robot Controls feat(app): add Jupyter Notebook button to robot's Advanced Settings Sep 9, 2020
@mcous
Copy link
Contributor Author

mcous commented Sep 9, 2020

Copy + placement approval from Support + UX via 👍's in Slack

@mcous mcous merged commit d615d2d into edge Sep 9, 2020
@mcous mcous deleted the app_feat-jupyter-button branch September 9, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Ticket is a feature request / PR introduces a feature robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). ux review required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: display link to jupyter notebook in robot settings page
3 participants