Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): fix tip probe button in apiV1 protocols #6318

Merged
merged 1 commit into from
Aug 10, 2020
Merged

fix(app): fix tip probe button in apiV1 protocols #6318

merged 1 commit into from
Aug 10, 2020

Conversation

b-cooper
Copy link
Contributor

Overview

Fix bug that @nusrat813 identified in QA, where tip probe button would not render for apiV1 protocols.

Review requests

  • Should be able to tip probe with an apiV1 protocol

Risk assessment

low

@b-cooper b-cooper requested a review from a team as a code owner August 10, 2020 17:29
@b-cooper b-cooper requested review from Kadee80, a team and ahiuchingau and removed request for a team August 10, 2020 17:29
@b-cooper b-cooper added app Affects the `app` project fix PR fixes a bug hmg hardware, motion, and geometry ready for review labels Aug 10, 2020
sfoster1
sfoster1 approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my robot!

@sfoster1 sfoster1 requested a review from nusrat813 August 10, 2020 17:59
nusrat813
nusrat813 approved these changes Aug 10, 2020
View reviewed changes
Copy link

@nusrat813 nusrat813 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested - working as intended

@b-cooper b-cooper merged commit 3b75f5d into chore_release-3.20.0 Aug 10, 2020
@b-cooper b-cooper deleted the app_fix-v1-tip-probe branch August 10, 2020 18:03
@b-cooper b-cooper restored the app_fix-v1-tip-probe branch August 11, 2020 19:11
@b-cooper b-cooper deleted the app_fix-v1-tip-probe branch August 11, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nusrat813 nusrat813 nusrat813 approved these changes

@sfoster1 sfoster1 sfoster1 approved these changes

@Kadee80 Kadee80 Awaiting requested review from Kadee80

@ahiuchingau ahiuchingau Awaiting requested review from ahiuchingau

Assignees
No one assigned
Labels
app Affects the `app` project fix PR fixes a bug hmg hardware, motion, and geometry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@b-cooper @sfoster1 @nusrat813