-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api, app): Clear instrument offset before performing deck calibration #6208
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python side looks good (haven't tested though) but we should change the FE copy a bit
You must restart your robot to finish the initial robot calibration | ||
process and have the new settings take effect. It may take several | ||
minutes for your robot to restart. | ||
Please note that as a result of the new deck calibration data, your |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe cut this para as discussed yesterday? I think just the final para ("In order to effectively use..." is enough of a warning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok, I misunderstood. Will remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending QA and UX review
0275770
to
4631945
Compare
Codecov Report
@@ Coverage Diff @@
## edge #6208 +/- ##
=======================================
Coverage ? 79.58%
=======================================
Files ? 199
Lines ? 18420
Branches ? 0
=======================================
Hits ? 14660
Misses ? 3760
Partials ? 0
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested - working as intended
If you start and then abort a deck calibration, is the pipette calibration still cleared? (If so, I don't think it would be a big problem—just looking out for surprises.) |
Overview
Closes #5022 by resetting instrument offset for all pipettes any time a new deck calibration begins. Some design changes were also added in the app by following instructions from this design.
Changelog
endpoints.py
and reload the current pip instrument offset to be (0, 0, 0)endpoints.py
as it's no longer relevantReview requests
Please check that the code place for resetting instrument offset etc are OK.
Test Plan
a. Modify your instrument offset (the value in
/data/robot_settings.json
underinstrument_offset
and the mount and type of pipette you'll use for deck calibration - the output of tip probe) to be bad, for instance having a value of 20 in its z component.b. Run deck calibration, trying to do a good job.
c. verify that after the robot restarts, the deck calibration is obviously incorrect - if you modified the z component of instrument offset, the deck calibration z offset should be very wrong
make push
and building the app on this pr withmake -C app dev
a. Edit
/data/robot_settings.json
and verify that the value underinstrument_offset
for the mount and type of pipette used for deck calibration is still bad and largeb. Run deck calibration, trying to do a good job
c. When ending deck calibration, the button should say "save and exit" rather than "save and restart robot". The robot should not restart when you click the button
d. Edit
/data/robot_settings.json
and verify that theinstrument_offset
for the mount and type of pipette you did deck calibration with is now(0, 0, 0)
e. Edit
/data/gantry_calibration.json
and verify that the deck calibration is not bad in the same way it was in 1cf. Run the calibrate-to-crosses protocol used by the labware creator. Run tip probe and check that the pipettes move to the crosses accurately (or as accurately as they normally do).
Let me know if you have any other questions!
Risk assessment
Medium. There was concern that customers would be confused by the new messaging at the end of the deck calibration program in the app. Please make sure we are OK with this language before merging.