Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): update link to support center #6087

Merged
merged 1 commit into from
Jul 8, 2020
Merged

fix(app): update link to support center #6087

merged 1 commit into from
Jul 8, 2020

Conversation

bndo
Copy link
Contributor

@bndo bndo commented Jul 8, 2020

Overview

The support center has been re-organized. This PR addresses that by linking to the root page.

Review requests

Make sure this links to the main page of the support center

Risk assessment

Low risk!

@bndo bndo requested review from mcous and SyntaxColoring July 8, 2020 17:14
@bndo bndo requested a review from a team as a code owner July 8, 2020 17:14
Copy link
Contributor

@mcous mcous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a server-side redirect, too? Edit: not sure how to get CloudFront to do that, though

@bndo bndo added the app Affects the `app` project label Jul 8, 2020
@SyntaxColoring
Copy link
Contributor

Does this need a server-side redirect, too? Edit: not sure how to get CloudFront to do that, though

Nope. This PR, on its own, is enough to fix the broken link.

Separately, I'm working on a proposal to avoid this kind of breakage in the future, and that will involve server-side redirects. But for now, no, it's not necessary.

@bndo bndo merged commit be05ef9 into edge Jul 8, 2020
@bndo bndo deleted the support-link-fixup branch July 8, 2020 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants