Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): calcheck: content fixups #5989

Merged
merged 3 commits into from
Jun 23, 2020
Merged

fix(app): calcheck: content fixups #5989

merged 3 commits into from
Jun 23, 2020

Conversation

sfoster1
Copy link
Member

Small content fixes for deck calibration check

  • Correct description on robot controls page
  • Correct CTA on bad calibration after tip pickup out of range check

Testing

  • Check that the words are correct

Risk

None, content only

@sfoster1
fix(app): calcheck: content fixups
a4fbd23 
- Correctly describe the calibration check feature on the robot controls
page
- Correctly recommend deck calibration if tip pickup is incorrect
@sfoster1 sfoster1 added app Affects the `app` project fix PR fixes a bug labels Jun 23, 2020
@sfoster1 sfoster1 requested review from a team, shlokamin and Laura-Danielle and removed request for a team June 23, 2020 20:34
@sfoster1 sfoster1 requested a review from a team as a code owner June 23, 2020 20:35
Laura-Danielle
Laura-Danielle approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@Laura-Danielle Laura-Danielle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nioce

@sfoster1 sfoster1 merged commit 21b5e4e into chore_release-3.19.0 Jun 23, 2020
@sfoster1 sfoster1 deleted the app_update-check-cal-description branch June 23, 2020 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Laura-Danielle Laura-Danielle Laura-Danielle approved these changes

@shlokamin shlokamin Awaiting requested review from shlokamin

Assignees
No one assigned
Labels
app Affects the `app` project fix PR fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfoster1 @Laura-Danielle