fix(app): calcheck: fix display of bad deck transform #5988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like 2bb54a9 accidentally changed the value for a bad deck transform value from the api, might have been an overzealous find and replace. This value should match the value in opentrons.calibration.helper_classes
sfoster1
requested review from
a team,
mcous and
ahiuchingau
and removed request for
a team
mcous
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like 2bb54a9 accidentally changed
the value for a bad deck transform value from the api, might have been
an overzealous find and replace. This value should match the value in
opentrons.calibration.helper_classes
Testing
Risk assessment
Low, but check both the individual step outcome and the end of flow summary