Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix cal check tip rack images at large window sizes #5841

Merged
merged 1 commit into from
Jun 9, 2020

Conversation

b-cooper
Copy link
Contributor

@b-cooper b-cooper commented Jun 8, 2020

overview

Fix issue where tip rack images in robot calibration check introduction screen overstepped their bounding border at larger window sizes of the run app (as seen in UAT).

changelog

applied some max height and width restrictions for the image and its container.

risk assessment

None

@b-cooper b-cooper requested a review from a team as a code owner June 8, 2020 19:41
@b-cooper b-cooper requested review from IanLondon and removed request for a team June 8, 2020 19:41
@b-cooper b-cooper added the app Affects the `app` project label Jun 8, 2020
@b-cooper b-cooper requested review from a team and Laura-Danielle and removed request for a team June 8, 2020 19:42
@b-cooper b-cooper added the fix PR fixes a bug label Jun 8, 2020
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@b-cooper b-cooper merged commit 065ce49 into edge Jun 9, 2020
@b-cooper b-cooper deleted the app_fix-p1000-tiprack-cal-check branch June 9, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project fix PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants