fix(app): interpolate session type into session exit event name #5804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
To aid usability/inspectability of the analytics platform, the analytics event named 'sessionExit' (which was never released, only recently merged into edge by #5780), has been altered to interpolate the session type into the event name as well (e.g. 'calibrationCheckSessionExit').
Note: the object still includes a property
sessionType: 'calibrationCheck', that can be seen as redundant, though it still acts as a record of the actual session type in code, without string parsing.risk assessment
none