Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(js): update lodash to 4.17.15 #5788

Merged
merged 2 commits into from
Jun 1, 2020
Merged

feat(js): update lodash to 4.17.15 #5788

merged 2 commits into from
Jun 1, 2020

Conversation

IanLondon
Copy link
Contributor

@IanLondon IanLondon commented Jun 1, 2020

overview

Our prev version of lodash has a security alert, this is a patch bump to bring us to the latest lodash version.

Also, this moves the 2 peer dependencies of Components Library into regular dependencies. They're lodash and classnames, not really appropriate for peer deps.

changelog

review requests

  • code review
  • CI passes, smoke test JS projects

risk assessment

affects all JS projects, but shouldn't be too risky

@IanLondon IanLondon requested review from mcous and a team June 1, 2020 18:14
@IanLondon IanLondon requested a review from a team as a code owner June 1, 2020 18:14
@IanLondon IanLondon requested review from a team, amitlissack, Kadee80 and shlokamin and removed request for a team June 1, 2020 18:14
@IanLondon IanLondon requested a review from a team as a code owner June 1, 2020 18:37
Copy link
Contributor

@mcous mcous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IanLondon IanLondon merged commit 5a145dc into edge Jun 1, 2020
@IanLondon IanLondon deleted the js_upgrade-lodash branch June 1, 2020 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants