Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix up calibration check copy #5779

Merged
merged 10 commits into from
Jun 1, 2020
Merged

Conversation

b-cooper
Copy link
Contributor

overview

Implement copy changes from updated designs.

changelog

  • all references to "deck calibration check" should now be "robot calibration check"
  • deck transform errors should link to correct deck calibration article
  • errors that are either from an ambiguous source, or instrument offset are sent to support

review requests

Look over copy for typos etc.

risk assessment

Low risk, mostly copy changes, very little code, all behind ff

@b-cooper b-cooper requested a review from a team as a code owner May 29, 2020 21:35
@b-cooper b-cooper requested review from IanLondon, a team and ahiuchingau and removed request for a team May 29, 2020 21:35
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy change lgtm

@b-cooper b-cooper merged commit 57b9ca8 into edge Jun 1, 2020
@b-cooper b-cooper deleted the app_cal-check-final-copy-pass branch June 1, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants