Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): add network interface collection to system-info #5764

Merged
merged 3 commits into from
May 29, 2020

Conversation

mcous
Copy link
Contributor

@mcous mcous commented May 28, 2020

overview

This PR adds simple network interface information collection to the app. The app-shell polls the OS for its active network interfaces (default 30 second poll) and places the list of active interfaces in state. If it recognizes that the MAC address of any of those active interfaces match the serial number of any U2E devices also in state, it will add the IP address to the UI, as well as the support profile and the analytics profile (for analytics, it will be anonymized to a boolean for "is there an IPv4 assigned?")

Closes #5397. See ticket for acceptance criteria.

changelog

  • feat(app): add network interface collection to system-info

review requests

  1. Open your app
  2. Connect a robot with the robot turned off
  3. You should see the device show up without a "Network Interface" in the "Networking & System" page
  4. Turn on the robot
  5. Eventually, (may take a minute or two) the card should update to show an active network interface along with an IP address or two

risk assessment

Low. Although this PR relates to connectivity, it does not change anything about connectivity. It's a purely information surfacing change. Additionally, unit test coverage is good.

@mcous mcous added feature Ticket is a feature request / PR introduces a feature app Affects the `app` project ready for review robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). labels May 28, 2020
@mcous mcous requested a review from a team as a code owner May 28, 2020 18:48
@mcous mcous requested review from b-cooper, a team, amitlissack and sanni-t and removed request for a team May 28, 2020 18:48
Copy link
Contributor

@b-cooper b-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, tested on OSX with robot and behaved as expected

Copy link
Member

@sanni-t sanni-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Worked on my mac

@mcous mcous merged commit 7d64efa into edge May 29, 2020
@mcous mcous deleted the app_system-info-net-iface branch May 29, 2020 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project feature Ticket is a feature request / PR introduces a feature robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add system networking interface info collection to app
3 participants