-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app, app-shell): add ability to disable discovery cache #5759
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Initial thoughts
app/src/components/NetworkSettingsCard/toggleDiscoveryCaching.js
Outdated
Show resolved
Hide resolved
app/src/components/NetworkSettingsCard/toggleDiscoveryCaching.js
Outdated
Show resolved
Hide resolved
app/src/components/NetworkSettingsCard/toggleDiscoveryCaching.js
Outdated
Show resolved
Hide resolved
app/src/components/NetworkSettingsCard/DisableDiscoveryCache.js
Outdated
Show resolved
Hide resolved
app/src/components/NetworkSettingsCard/__tests__/DisableDiscoveryCache.test.js
Outdated
Show resolved
Hide resolved
app/src/components/NetworkSettingsCard/__tests__/DisableDiscoveryCache.test.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last two changes to get typechecking and tests passing
app/src/components/NetworkSettingsCard/__tests__/DisableDiscoveryCache.test.js
Outdated
Show resolved
Hide resolved
app/src/components/NetworkSettingsCard/__tests__/NetworkSettingsCard.test.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and behavior LGTM 🌵
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works on my 🤖 !
Closes #4853
overview
This PR adds ability to disable caching new robots to
discovery.json
using a toggle.changelog
discovery.json
ondiscovery.disableCache
changereview requests
/server/name
POST request with body{"name": "Some new name"}
)risk assessment
Medium. Touches implementation of discovery logic but is quite a small change.