Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App: Clean-up pipette and robot support profile update logic #5490

Closed
mcous opened this issue Apr 27, 2020 · 0 comments
Closed

App: Clean-up pipette and robot support profile update logic #5490

mcous opened this issue Apr 27, 2020 · 0 comments
Labels
app Affects the `app` project refactor robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).

Comments

@mcous
Copy link
Contributor

mcous commented Apr 27, 2020

overview

The app's support profile update logic for setting connected robot and pipette details is a little too complicated and not covered by unit tests. The code should be refactored to have unit test coverage and set each item in the profile more atomically.

See #5482 (comment) and TODO comment in app/src/support/profile.js for more details
@mcous mcous added app Affects the `app` project refactor robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). labels Apr 27, 2020
@mcous mcous mentioned this issue Apr 27, 2020
Merged
10 tasks
@bndo bndo closed this as completed Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app Affects the `app` project refactor robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bndo @mcous