feat(app): guide the user through leveling gen2 multis #5348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new flow added in to change pipette guides the user through making sure their gen2 multi pipettes are level, using the extension block and manually pulling the pipettes against it. Closes #5344
sfoster1
added
feature
Codecov Report
@@ Coverage Diff @@
## edge #5348 +/- ##
==========================================
+ Coverage 63.44% 66.47% +3.02%
==========================================
Files 1076 1097 +21
Lines 30649 33938 +3289
==========================================
+ Hits 19445 22559 +3114
- Misses 11204 11379 +175
Continue to review full report at Codecov.
|
b-cooper
reviewed
Apr 2, 2020
| ) | ||
| } | ||
|
|
||
| function ExitButton(props: Props) { |
There was a problem hiding this comment.
Nit: because this component is so shallow, I'd probably place the instance of PrimaryButton directly in the LevelPipette component for clarity in this file. This kind of abstraction feels unnecessary. You could probably make the same argument for the Status component. It's not really adding branching logic, just a haven for some variable declarations.
the videos are going to be long enough we don't want to force people to loop
b-cooper
approved these changes
Apr 14, 2020
mcous
suggested changes
Apr 16, 2020
mcous
approved these changes
Apr 16, 2020
IanLondon
pushed a commit
that referenced
this pull request
Apr 22, 2020
Adds a new flow to attach pipette that guides the user through making sure their gen2 multi pipettes are level, using the extension block and manually pulling the pipettes against it. It involves four new videos and therefore also adds webpack support for .webm files. Closes #5344
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new flow added in to change pipette guides the user through making
sure their gen2 multi pipettes are level, using the extension block and
manually pulling the pipettes against it.
Closes #5344
Design reference:
new text on pre-attach screen: https://app.zeplin.io/project/5aa97729db58a2192f10d0d6/screen/5e839ed0f792546d4c858d30
leveling screen: https://app.zeplin.io/project/5aa97729db58a2192f10d0d6/screen/5e839ed07319a9140ea11305
Status
Ready for test and review!
Risk Assessment
Really low, this is just adding a screen to the change pipette flow and slightly modifying the text in another