fix(app): alignment in thermocycler card cycle info #5320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release_3.17.0 #5320 +/- ##
===============================================
Coverage 63.12% 63.12%
===============================================
Files 1061 1061
Lines 30161 30161
===============================================
Hits 19038 19038
Misses 11123 11123
Continue to review full report at Codecov.
|
b-cooper
force-pushed
the
app_fix-tc-card-cycle-alignment
branch
from
e43967d to
6fd1eaf
Compare
b-cooper
force-pushed
the
app_fix-tc-card-cycle-alignment
branch
from
6fd1eaf to
70f2cc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an alignment issue within the Thermocycler's run card cycle info.
The Time remaining should be on a new row beneath the cycle and step counts, but they were all scrunching together.
This also repairs a regression in formatting the time remaining, that was introduced in the shift away from moment in #5127 . For instance, ten seconds remaining was displaying as 19:00:10 and it should correctly display as 00:00:10.