Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): enable gen2 multi pipettes #5297

Merged
merged 2 commits into from
Mar 27, 2020
Merged

feat(app): enable gen2 multi pipettes #5297

merged 2 commits into from
Mar 27, 2020

Conversation

sfoster1
Copy link
Member

Closes #4698

@sfoster1 sfoster1 requested review from a team March 26, 2020 16:56
@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #5297 into edge will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge    #5297   +/-   ##
=======================================
  Coverage   63.10%   63.11%           
=======================================
  Files        1061     1061           
  Lines       30157    30153    -4     
=======================================
- Hits        19032    19030    -2     
+ Misses      11125    11123    -2     
Impacted Files Coverage Δ
...p/src/components/ChangePipette/PipetteSelection.js 0.00% <ø> (ø)
app/src/config/constants.js 100.00% <ø> (ø)
...mponents/modals/FilePipettesModal/PipetteFields.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6620ee...f7f7d82. Read the comment docs.

@sfoster1 sfoster1 force-pushed the app_enable-gen2-multi branch from d893c71 to 096a57a Compare March 26, 2020 19:56
Copy link
Contributor

@IanLondon IanLondon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally got api dev server running and tested with fake robot ✔️

@sfoster1 sfoster1 merged commit 707f0ab into edge Mar 27, 2020
@sfoster1 sfoster1 deleted the app_enable-gen2-multi branch March 27, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gen2Multi: Remove feature flag
2 participants