Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): accept mixed-case extensions for protocols and custom labware #5153

Merged
merged 3 commits into from
Mar 3, 2020
Merged

fix(app): accept mixed-case extensions for protocols and custom labware #5153

merged 3 commits into from
Mar 3, 2020

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Mar 3, 2020 •
edited
Loading

overview

This PR fixes an embarrassing mistake in the app's filename handling for custom labware and protocols: it expects all file extensions to be lowercase

Fixes #5151

changelog

  • fix(app): accept mixed-case extensions for protocols and custom labware

review requests

  • Uploading whatever-labware.JSON as custom labware works
  • Uploading whatever-protocol.JSON as a protocol works

@mcous mcous added app Affects the `app` project ready for review fix PR fixes a bug labels Mar 3, 2020
@mcous mcous requested review from SyntaxColoring and a team March 3, 2020 16:55
@mcous mcous requested a review from a team as a code owner March 3, 2020 16:55
@mcous mcous requested review from amitlissack and sanni-t and removed request for a team March 3, 2020 16:55
@codecov
Copy link

codecov bot commented Mar 3, 2020 •
edited
Loading

Codecov Report

Merging #5153 into edge will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge    #5153   +/-   ##
=======================================
  Coverage   69.01%   69.02%           
=======================================
  Files        1084     1085    +1     
  Lines       36068    36075    +7     
=======================================
+ Hits        24894    24901    +7     
  Misses      11174    11174
Impacted Files Coverage Δ
app/src/protocol/constants.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82b1f91...a7a5b41. Read the comment docs.

@mcous mcous changed the title fix(app): accept mixed-case .json extensions in custom labware fix(app): accept mixed-case extensions for protocols and custom labware Mar 3, 2020
@mcous mcous added 🕷️ SPDDRS robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). labels Mar 3, 2020
@mcous mcous requested review from a team, IanLondon and jen-fong and removed request for a team March 3, 2020 17:35
@IanLondon IanLondon mentioned this pull request Mar 3, 2020
Closed
IanLondon
IanLondon approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@IanLondon IanLondon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LgTm

@mcous mcous merged commit 12cce54 into edge Mar 3, 2020
@mcous mcous deleted the app_fix-mixed-case-labware-filenames branch March 3, 2020 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanLondon IanLondon IanLondon approved these changes

@SyntaxColoring SyntaxColoring Awaiting requested review from SyntaxColoring

@amitlissack amitlissack Awaiting requested review from amitlissack

@sanni-t sanni-t Awaiting requested review from sanni-t

@jen-fong jen-fong Awaiting requested review from jen-fong

Assignees
No one assigned
Labels
app Affects the `app` project fix PR fixes a bug robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: App accepts, but does not list, custom labware files ending in .JSON (all caps)
2 participants
@mcous @IanLondon