fix(app): use containers and instruments to set RPC pipette tip rack list #5147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…struments This works around a bug from the RPC API in PAPIv1 where a pipette may be reported to use no tip racks even if a tip rack itself reports usage by that same pipette
mcous
requested review from
a team,
amitlissack and
sanni-t
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## edge #5147 +/- ##
==========================================
+ Coverage 68.91% 68.92% +0.01%
==========================================
Files 1082 1084 +2
Lines 36045 36086 +41
==========================================
+ Hits 24839 24873 +34
- Misses 11206 11213 +7
Continue to review full report at Codecov.
|
mcous
requested review from
a team,
Kadee80 and
shlokamin
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
This works PR works around a "bug" from the RPC API in PAPIv1 (Existing expected bahavior? Who really knows?) that was discovered by an internal user.
A pipette may be reported to the app to use no tip racks even if a tip rack object used in the protocol reports usage by that same pipette. E.g. the session can come back with:
This appears to happen if one constructs the pipettes without using the
tip_racksargument of the constructor in PAPIv1. To work around this issue, the app will now build the tip rack usage list from both the RPC instruments and the RPC containers, instead of just the instruments.changelog
review requests
To test, upload a Protocol API v1 protocol that does not use the
tip_racksargument of the pipette constructors, but makes variouspick_up_tipandreturn_tipcallsThe added functionality is covered by unit tests, but is a very old, un-typed part of the app's source code.