Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: App should drop services from its discovery cache after a period of time #4854

Closed
1 task
mcous opened this issue Jan 24, 2020 · 1 comment
Closed
1 task
Labels
app Affects the `app` project feature Ticket is a feature request / PR introduces a feature robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).

Comments

@mcous
Copy link
Contributor

mcous commented Jan 24, 2020

overview

As a user that used to connect to a robot that I don't have anymore, I would like it to stop showing up in my app's robot list as "unable to find"

The app should clean services out of its discovery cache automatically after their last seen date becomes too old

acceptance criteria

  • If a robot doesn't advertise, respond on /health, nor respond on /server/update/health for 60 days, the app should remove it from its discovery.json cache

implementation notes

60 days subject to approval by UX / product / support

┆Issue is synchronized with this Wrike Task by Unito

@mcous mcous added app Affects the `app` project robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). feature Ticket is a feature request / PR introduces a feature labels Jan 24, 2020
@mcous
Copy link
Contributor Author

mcous commented Sep 1, 2020

App will automatically clear out stale IP addresses for a given robot, which should resolve much of the problems this ticket was written to address. Given the large UX implications of this ticket, going to close it out in favor of a more considered approach when we actually decide to tackle discrete removal of robots from the list

@mcous mcous closed this as completed Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project feature Ticket is a feature request / PR introduces a feature robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
Projects
None yet
Development

No branches or pull requests

1 participant