Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(app): add link to docs in resources card #4606

Merged
merged 1 commit into from
Dec 13, 2019
Merged

feat(app): add link to docs in resources card #4606

merged 1 commit into from
Dec 13, 2019

Conversation

sfoster1
Copy link
Member

Make sure it renders and the link clicks

@sfoster1 sfoster1 added feature Ticket is a feature request / PR introduces a feature app Affects the `app` project small labels Dec 13, 2019
@sfoster1 sfoster1 requested review from Kadee80 and a team December 13, 2019 18:04
@codecov
Copy link

codecov bot commented Dec 13, 2019 •
edited
Loading

Codecov Report

Merging #4606 into edge will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge    #4606   +/-   ##
=======================================
  Coverage   57.74%   57.74%           
=======================================
  Files         927      927           
  Lines       26002    26002           
=======================================
  Hits        15015    15015           
  Misses      10987    10987
Impacted Files Coverage Δ
app/src/components/Resources/index.js 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9388391...17ec6e0. Read the comment docs.

Kadee80
Kadee80 approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@Kadee80 Kadee80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕
API resource link renders and links correctly to docs

@sfoster1 sfoster1 merged commit 21ec9ff into edge Dec 13, 2019
@sfoster1 sfoster1 deleted the app_add-docs-card branch December 13, 2019 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kadee80 Kadee80 Kadee80 approved these changes

Assignees
No one assigned
Labels
app Affects the `app` project feature Ticket is a feature request / PR introduces a feature small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfoster1 @Kadee80