Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): prevent user from proceeding if uploaded protocol has no steps #4381

Merged
merged 1 commit into from
Nov 6, 2019
Merged

fix(app): prevent user from proceeding if uploaded protocol has no steps #4381

merged 1 commit into from
Nov 6, 2019

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Nov 6, 2019 •
edited
Loading

overview

If a protocol has no errors, the app will now display an error message in the FileInfo page and disable the calibration and run pages

Closes #3121

2019-11-06 12 01 03

changelog

  • fix(app): prevent user from proceeding if uploaded protocol has no steps

review requests

  1. Upload a protocol with no aspirates and dispenses
  • An error is show in the FileInfo page
  • Calibrate and Run nav buttons are disabled

@mcous mcous added app Affects the `app` project ready for review fix PR fixes a bug labels Nov 6, 2019
@mcous mcous requested a review from b-cooper November 6, 2019 16:58
Kadee80
Kadee80 approved these changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@Kadee80 Kadee80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 👣

@mcous mcous merged commit a8344e9 into edge Nov 6, 2019
@mcous mcous deleted the app_alert-no-protocol-steps branch November 6, 2019 18:08
@mcous mcous mentioned this pull request Nov 8, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kadee80 Kadee80 Kadee80 approved these changes

@b-cooper b-cooper Awaiting requested review from b-cooper

Assignees
No one assigned
Labels
app Affects the `app` project fix PR fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run app warning if protocol has no steps
2 participants
@mcous @Kadee80